Skip to content

Remove useless Arduino.h include #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

Remove useless Arduino.h include #58

merged 1 commit into from
Apr 19, 2021

Conversation

facchinm
Copy link
Contributor

No description provided.

@facchinm facchinm requested a review from aentinger April 19, 2021 09:48
@github-actions
Copy link

Memory usage change @ 629884d

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 +8 - +8 +0.03 - +0.03 0 - 0 0.0 - 0.0
arduino:avr:nano 🔺 +8 - +14 +0.03 - +0.05 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed:nano33ble N/A N/A N/A N/A
arduino:megaavr:uno2018:mode=off ❔ -18 - +8 -0.04 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +88 - +88 +0.03 - +0.03 0 - 0 0.0 - 0.0
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:avr:leonardo 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0
arduino:avr:nano 8 0.03 0 0.0 8 0.03 0 0.0 14 0.05 0 0.0 14 0.05 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0 8 0.03 0 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed:nano33ble N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:megaavr:uno2018:mode=off 8 0.02 0 0.0 8 0.02 0 0.0 -18 -0.04 0 0.0 -18 -0.04 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0
arduino:samd:mkrwifi1010 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0 88 0.03 0 0.0
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0
arduino:avr:nano,8,0.03,0,0.0,8,0.03,0,0.0,14,0.05,0,0.0,14,0.05,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0,8,0.03,0,0.0
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,,,,,
arduino:mbed:nano33ble,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,,,,,
arduino:megaavr:uno2018:mode=off,8,0.02,0,0.0,8,0.02,0,0.0,-18,-0.04,0,0.0,-18,-0.04,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0
arduino:samd:mkrwifi1010,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0,88,0.03,0,0.0

@aentinger aentinger merged commit 4cd74c2 into master Apr 19, 2021
@aentinger aentinger deleted the fix_mbed_build branch April 19, 2021 10:06
@ant32 ant32 mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@facchinm @dpslwk @bungernut @aentinger @tomtobback @per1234